Skip to content

Docs: document 'manager' and '_log' attrs of logging.Logging#108145

Merged
erlend-aasland merged 2 commits into
python:mainfrom
erlend-aasland:docs/logging-manager-log
Aug 20, 2023
Merged

Docs: document 'manager' and '_log' attrs of logging.Logging#108145
erlend-aasland merged 2 commits into
python:mainfrom
erlend-aasland:docs/logging-manager-log

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Aug 19, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Authored by @AA-Turner

📚 Documentation preview 📚: https://cpython-previews--108145.org.readthedocs.build/

@erlend-aasland erlend-aasland requested a review from vsajip as a code owner August 19, 2023 17:04
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting core review labels Aug 19, 2023
@erlend-aasland erlend-aasland mentioned this pull request Aug 19, 2023
Merged
AA-Turner
AA-Turner approved these changes Aug 19, 2023
View reviewed changes

@AA-Turner AA-Turner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels cheating to approve something I wrote!

A

@erlend-aasland

erlend-aasland commented Aug 19, 2023

Copy link
Copy Markdown
Contributor Author

Feels cheating to approve something I wrote!

Well, I approved it by making it a PR :)

@erlend-aasland erlend-aasland enabled auto-merge (squash) August 20, 2023 15:52
@erlend-aasland erlend-aasland merged commit f904aa4 into python:main Aug 20, 2023
@miss-islington

This comment was marked as outdated.

Sign in to view
@miss-islington

This comment was marked as outdated.

Sign in to view
@miss-islington

This comment was marked as outdated.

Sign in to view
@erlend-aasland erlend-aasland deleted the docs/logging-manager-log branch August 20, 2023 16:02
@erlend-aasland erlend-aasland added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes and removed needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Aug 21, 2023
@miss-islington

miss-islington commented Aug 21, 2023

Copy link
Copy Markdown
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Aug 21, 2023

Copy link
Copy Markdown
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@bedevere-bot

bedevere-bot commented Aug 21, 2023

Copy link
Copy Markdown

GH-108189 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Aug 21, 2023
@bedevere-bot

bedevere-bot commented Aug 21, 2023

Copy link
Copy Markdown

GH-108190 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Aug 21, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 21, 2023
@erlend-aasland @miss-islington
Docs: document 'manager' and '_log' attrs of logging.Logging (pythonG…
a4b485e 
…H-108145)

(cherry picked from commit f904aa4)

Co-authored-by: Erlend E. Aasland <erlend@python.org>
Authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 21, 2023
@erlend-aasland @miss-islington
Docs: document 'manager' and '_log' attrs of logging.Logging (pythonG…
de5e2b4 
…H-108145)

(cherry picked from commit f904aa4)

Co-authored-by: Erlend E. Aasland <erlend@python.org>
Authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
serhiy-storchaka
serhiy-storchaka reviewed Aug 21, 2023
View reviewed changes
Comment thread Doc/library/logging.rst
@erlend-aasland erlend-aasland mentioned this pull request Aug 21, 2023
Closed
vsajip pushed a commit that referenced this pull request Aug 21, 2023
@miss-islington @erlend-aasland
[3.11] Docs: document 'manager' and '_log' attrs of logging.Logging (G…
a372274 
…H-108145) (GH-108189)

(cherry picked from commit f904aa4)
Authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Erlend E. Aasland <erlend@python.org>
Yhg1s pushed a commit that referenced this pull request Aug 21, 2023
@miss-islington @erlend-aasland
[3.12] Docs: document 'manager' and '_log' attrs of logging.Logging (G…
9cd15ca 
…H-108145) (#108190)

Docs: document 'manager' and '_log' attrs of logging.Logging (GH-108145)
(cherry picked from commit f904aa4)


Authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>

Co-authored-by: Erlend E. Aasland <erlend@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka left review comments
@vsajip vsajip vsajip approved these changes
@AA-Turner AA-Turner AA-Turner approved these changes

Assignees

@erlend-aasland erlend-aasland

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@erlend-aasland @miss-islington @bedevere-bot @vsajip @serhiy-storchaka @AA-Turner